yin-bo-Final commented on PR #16309: URL: https://github.com/apache/dubbo/pull/16309#issuecomment-4627689743
Thanks for the suggestion😊, I updated the PR to deprecate the two-argument method and migrated the mesh AddressMatch usage to the three-argument matchIpExpression API. I also added AddressMatch tests to cover IPv4 host:port matching, port mismatch, and IPv6 matching. And I noticed the field/method name is currently `cird`, which looks like a typo of `cidr`🤔, but I kept it unchanged in this PR to avoid introducing an unrelated compatibility change. If needed, I can handle the naming cleanup in a separate PR while keeping backward-compatible getCird/setCird methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
