AlexStocks commented on code in PR #135:
URL: https://github.com/apache/dubbo-getty/pull/135#discussion_r3600015010
##########
Makefile:
##########
@@ -36,7 +36,7 @@ test: clean
fmt: install-imports-formatter
# replace interface{} with any
- go run
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest
-category=efaceany -fix -test ./...
+ go run
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -any
-fix -test ./...
Review Comment:
[P2] 补充当前可复现证据：本次 CI 实际解析到 `gopls v0.23.0`，它要求 Go 1.26，因此虽然 workflow 声明 Go
1.23，格式步骤仍自动下载并切换到了 Go 1.26.5；在 `GOTOOLCHAIN=go1.23.12` 下该命令会直接失败。另外，`gopls
v0.21.0+` 已把这个 `gopls/internal/.../cmd/modernize` 入口标记为 deprecated，要求迁移到公开的
`golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize`。因此只替换 flag
仍保留了同一类上游漂移风险。建议改用公开入口、固定工具版本，并让该版本的最低 Go 要求与 CI 明确对齐。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
