AlexStocks commented on code in PR #135:
URL: https://github.com/apache/dubbo-getty/pull/135#discussion_r3600300541
##########
.github/workflows/github-actions.yml:
##########
@@ -28,7 +28,7 @@ jobs:
# If you want to matrix build , you can append the following list.
matrix:
go_version:
- - '1.23'
+ - '1.24'
Review Comment:
[P1] 保留 Go 1.23 兼容性测试，不要用工具要求替换代码测试矩阵
`go.mod` 仍声明 `go 1.23`，而这里是唯一的单测/Lint 矩阵。直接改成 1.24 后，后续代码即使引用 Go 1.24 新增的标准库
API 也会在 CI 通过，但 Go 1.23 用户会编译失败。`x/tools v0.38.0` 的 Go 1.24 要求只属于格式工具：请保留 Go
1.23 的代码测试任务，并把 format 拆到单独的 Go 1.24 job/step，或仅为该命令显式选择 1.24
工具链；如果项目确实要把最低版本提升到 1.24，则应同时更新 `go.mod` 和升级说明。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
