jiaming2li commented on issue #3338: URL: https://github.com/apache/dubbo-go/issues/3338#issuecomment-5109000744
> > [@Alanxtl](https://github.com/Alanxtl), I have a question: trace span is created inside the `OTel filter`, and on the consumer side that filter runs inside the cluster invoker. So retry, load-balance and router selection all happen before the span exists, so diagnostic events can't attach to span. Do I need to add a logical client span above the cluster to let retry/load-balance/router events attach? > > I understand your concern > > Wouldn't it be cleaner to keep only the upper logical client span? It represents the whole consumer RPC from the user's perspective, and retry/load-balance/router diagnostics can be recorded as events or attributes on that span. > > btw, are you in our wechat group? Got it. So what I need to complete is to add a new logical span above the cluster as upper span doesn't exist at present and remove the per-attempt filter spans. It is a big change, do you think it's ok? And how to join wechat group? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
