Alanxtl commented on issue #3338: URL: https://github.com/apache/dubbo-go/issues/3338#issuecomment-5127278380
> Thanks [@jiaming2li](https://github.com/jiaming2li). To avoid duplicate work, I will treat the cluster-level logical `CLIENT` span migration as your implementation scope. > > I still recommend keeping [#3551](https://github.com/apache/dubbo-go/pull/3551) focused on its current span-name and base-attribute changes, and delivering the cluster-level migration as a separate PR (or at least as clearly separated commits), because it changes the consumer span lifecycle and retry topology. Please let me know if you plan a different split. > > [@Alanxtl](https://github.com/Alanxtl) [@Oxidaner](https://github.com/Oxidaner), unless there is other ongoing work that overlaps, I would like to coordinate and implement the remaining non-overlapping parts of [#3338](https://github.com/apache/dubbo-go/issues/3338) after this boundary, including: > > * stable error category/code/source attributes; > * remaining timeout, rejection, codec and registry diagnostic events not covered by the logical-span work; > * W3C/B3/baggage/attachment propagation tests; > * Triple and Dubbo protocol coverage; > * trace/log/metric correlation; > * related samples and documentation. > > Could you please confirm this ownership boundary? I will not duplicate the logical-span work or the span-name/base-attribute work already covered by [@jiaming2li](https://github.com/jiaming2li) and [#3551](https://github.com/apache/dubbo-go/pull/3551). cool :) @Tsukikage7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
