Alanxtl commented on code in PR #3643:
URL: https://github.com/apache/dubbo-go/pull/3643#discussion_r3758695052
##########
protocol/triple/server.go:
##########
@@ -685,7 +682,8 @@ func (s *Server) saveServiceInfo(interfaceName string, info
*common.ServiceInfo,
ret.Metadata = info
s.mu.Lock()
defer s.mu.Unlock()
- // TODO(DMwangnima): using interfaceName is not enough, we need to
consider group and version
Review Comment:
ditto
##########
protocol/triple/server.go:
##########
@@ -549,12 +547,11 @@ func (s *Server) registerUnaryMethodHandler(procedure
string, m common.MethodInf
func(ctx context.Context, req *tri.Request) (*tri.Response,
error) {
args := extractUnaryInvocationArgs(req.Msg)
attachments := generateAttachments(req.Header())
- // Inject attachments
+ // Make incoming attachments available to invocation
filters and user code.
ctx = context.WithValue(ctx, constant.AttachmentKey,
attachments)
invo := invocation.NewRPCInvocation(m.Name, args,
attachments)
res := invoker.Invoke(ctx, invo)
- // TODO(DMwangnima): modify InfoInvoker to get a
unified processing logic
- // Please refer to server/InfoInvoker.Invoke()
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
