Snow-kal commented on code in PR #3643:
URL: https://github.com/apache/dubbo-go/pull/3643#discussion_r3758704228
##########
protocol/triple/server.go:
##########
@@ -240,12 +240,12 @@ func (s *Server) startTransport(callProtocol string,
tlsConf *tls.Config) {
}()
}
-func (s *Server) registerServiceHandlers(invoker base.Invoker, info
*common.ServiceInfo, hanOpts []tri.HandlerOption) {
+func (s *Server) registerServiceHandlers(invoker base.Invoker, info
*common.ServiceInfo, handlerOpts []tri.HandlerOption) {
url := invoker.GetURL()
// IDLMode means that this will only be set when
// The new triple is started in non-IDL mode.
- // TODO: remove IDLMode when config package is removed
Review Comment:
好的 感谢提醒 我去把这些TODO恢复
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
