xiaobaicai66695 opened a new pull request, #3658:
URL: https://github.com/apache/dubbo-go/pull/3658

   ### What this PR does
   
   Fixes the v3.0 condition-router parser assigning `enabled` and `force` in 
reverse order.
   
   Before this change, the common combination below disabled the router at 
runtime:
   
   ```yaml
   enabled: true
   force: false
   ```
   
   The parser interpreted it as `enable=false` and `force=true`, so 
`DynamicRouter.Route` returned the original invoker list without applying the 
condition.
   
   ### Changes
   
   - assign `RouterConfig.Force` to `force` and `RouterConfig.Enabled` to 
`enable`;
   - add regression coverage for asymmetric v3.0 boolean flags;
   - verify that a runtime update from v3.1 to v3.0 replaces the active router 
and applies the v3.0 destination condition.
   
   ### Testing
   
   ```text
   go test ./cluster/router/condition -count=1
   ok dubbo.apache.org/dubbo-go/v3/cluster/router/condition
   ```
   
   Fixes #3656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to