Copilot commented on code in PR #3660:
URL: https://github.com/apache/dubbo-go/pull/3660#discussion_r3788390800
##########
config_center/configurator/override.go:
##########
@@ -56,7 +56,7 @@ func (c *overrideConfigurator) Configure(url *common.URL) {
}
// branch for version 2.7.x
- apiVersion := c.configuratorUrl.GetParam(constant.ConfigVersionKey, "")
+ apiVersion := c.configuratorUrl.GetParam(constant.RuleConfigVersionKey,
"")
if len(apiVersion) != 0 {
Review Comment:
This comment is now misleading: the non-empty configVersion branch handles
both 2.7.x-style rules and v3 rules (which further dispatch via
constant.APIVersion). Updating it will reduce confusion when reading
Configure().
##########
config_center/configurator/override.go:
##########
@@ -153,7 +153,7 @@ func getConditionKeys() *gxset.HashSet {
conditionKeys.Add(constant.VersionKey)
conditionKeys.Add(constant.ApplicationKey)
conditionKeys.Add(constant.SideKey)
- conditionKeys.Add(constant.ConfigVersionKey)
+ conditionKeys.Add(constant.RuleConfigVersionKey)
conditionKeys.Add(constant.CompatibleConfigKey)
Review Comment:
getConditionKeys() excludes RuleConfigVersionKey but no longer excludes the
legacy ConfigVersionKey ("config-center.configVersion"). If an override URL
still carries that legacy key, it would now be propagated onto the target URL
via CloneExceptParams(), which is likely unintended metadata leakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
