AlexStocks commented on code in PR #3660:
URL: https://github.com/apache/dubbo-go/pull/3660#discussion_r3788484601
##########
config_center/configurator/override.go:
##########
@@ -153,7 +153,7 @@ func getConditionKeys() *gxset.HashSet {
conditionKeys.Add(constant.VersionKey)
conditionKeys.Add(constant.ApplicationKey)
conditionKeys.Add(constant.SideKey)
- conditionKeys.Add(constant.ConfigVersionKey)
+ conditionKeys.Add(constant.RuleConfigVersionKey)
conditionKeys.Add(constant.CompatibleConfigKey)
Review Comment:
[P1] 这里不能只把排除键替换成新的 configVersion，旧 config-center.configVersion 仍需要兼容处理
固定当前 Base/Head 的同一探针使用旧键 config-center.configVersion=v3.0、不匹配当前 application
的 V3 ConditionMatch，并配置 loadbalance=roundrobin。Base 保持目标 URL 的 random
且不复制控制键；当前 Head 则落入 configureDeprecated()，绕过 ConditionMatch 把目标改成
roundrobin，还把旧键 v3.0 复制进业务
URL。已有旧格式规则会因此无条件作用到非目标实例。请同时识别并排除两个键，明确两者并存时的优先级，并增加旧键 + 不匹配 V3 条件的兼容回归测试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
