lizining1231 commented on code in PR #3663:
URL: https://github.com/apache/dubbo-go/pull/3663#discussion_r3788893372
##########
protocol/triple/triple_protocol/client_stream.go:
##########
@@ -72,7 +72,8 @@ func (c *ClientStreamForClient) Send(request any) error {
}
// CloseAndReceive closes the send side of the stream and waits for the
-// response.
+// response. If closing the send side or receiving the response fails, the
+// receive side is closed before the error is returned.
Review Comment:
Thanks. Updated the comment to say `CloseResponse` is called on a
best-effort basis before the error is returned, matching the implementation
that discards the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
