lizining1231 commented on code in PR #3663:
URL: https://github.com/apache/dubbo-go/pull/3663#discussion_r3788895815


##########
protocol/triple/triple_protocol/client_stream_test.go:
##########
@@ -107,3 +108,197 @@ type nopStreamingClientConn struct {
 func (c *nopStreamingClientConn) Receive(msg any) error {
        return nil
 }
+
+// stubStreamingClientConn is a configurable StreamingClientConn used to
+// exercise close paths, error propagation and empty metadata without
+// involving a real transport.
+type stubStreamingClientConn struct {
+       StreamingClientConn
+
+       sendErr      error
+       receiveErr   error
+       closeReqErr  error
+       closeRespErr error
+       requestHdr   http.Header
+       responseHdr  http.Header
+       responseTrlr http.Header
+
+       sendCalls      int
+       receiveCalls   int
+       closeReqCalls  int
+       closeRespCalls int
+}
+
+func (c *stubStreamingClientConn) Send(any) error {

Review Comment:
   Thanks. Added explicit `Spec()` and `Peer()` zero-value implementations on 
`stubStreamingClientConn`, matching `stubHandlerConn` and avoiding the nil 
embedded-interface panic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to