HTFSince2018 commented on code in PR #3674:
URL: https://github.com/apache/dubbo-go/pull/3674#discussion_r3801953826
##########
global/triple_config.go:
##########
@@ -21,27 +21,27 @@ package global
// TripleConfig represents the config of triple protocol.
type TripleConfig struct {
- //
- // for server
- //
- // MaxServerSendMsgSize defines the max size of server send message,
1mb=1000kb=1000000b 1mib=1024kb=1048576b.
- // more detail to see
https://pkg.go.dev/github.com/dustin/go-humanize#pkg-constants
+ // MaxServerSendMsgSize defines the maximum size of messages sent by
server.
+ // Supported units include 1mb=1000kb=1000000b and 1mib=1024kb=1048576b.
+ // For more details, see
https://pkg.go.dev/github.com/dustin/go-humanize#pkg-constants.
MaxServerSendMsgSize string `yaml:"max-server-send-msg-size"
json:"max-server-send-msg-size,omitempty"`
- // MaxServerRecvMsgSize defines the max size of server receive message.
+
+ // MaxServerRecvMsgSize defines the maximum size of messages received
by server.
MaxServerRecvMsgSize string `yaml:"max-server-recv-msg-size"
json:"max-server-recv-msg-size,omitempty"`
- // Http3 holds the HTTP/3 transport configuration.
+
+ // Http3 holds the HTTP/3 transport configuration for server and client.
Http3 *Http3Config `yaml:"http3" json:"http3,omitempty"`
- // Cors configures CORS for Triple protocol handlers.
+
+ // Cors configures CORS for Triple protocol handlers on server.
Cors *CorsConfig `yaml:"cors" json:"cors,omitempty"`
- // OpenAPI configures OpenAPI documentation generation.
+
+ // OpenAPI configures OpenAPI documentation generation for server.
OpenAPI *OpenAPIConfig `yaml:"openapi" json:"openapi,omitempty"`
- //
- // for client
- //
Review Comment:
Thank you for pointing this out. I have restored the original "for client"
section comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
