AlexStocks commented on code in PR #3674:
URL: https://github.com/apache/dubbo-go/pull/3674#discussion_r3802831472
##########
global/http3_config.go:
##########
@@ -19,27 +19,30 @@ package global
// Http3Config represents the config of http3 protocol.
type Http3Config struct {
- // Enable defines whether to enable HTTP/3 support.
- // When set to true, both HTTP/2 and HTTP/3 servers will be started
simultaneously.
- // When set to false, only HTTP/2 server will be started.
+ // Enable defines whether HTTP/3 support is enabled for server and
client.
+ // When true, server starts both HTTP/2 and HTTP/3, and client uses a
dual HTTP/2 and HTTP/3 transport.
Review Comment:
[P2] 这里把客户端行为写成了无条件创建 HTTP/2+HTTP/3 dual transport，但
protocol/triple/client.go:247-250 在没有有效 TLS 时会直接返回错误，实际不会创建 transport；服务端的
HTTP/3 路径同样要求 TLS。请明确说明 HTTP/3 需要有效 TLS，且只有 TLS 配置有效时客户端才会使用 dual
transport，避免用户仅按这个结构体注释打开 enable 后遇到与文档不符的初始化失败。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
