DaWesen opened a new pull request, #3678:
URL: https://github.com/apache/dubbo-go/pull/3678

   ### Description
   
   This PR improves the comments and test coverage of the service discovery 
metadata customizers.
   
   - Adds doc comments to metadataServiceURLParamsMetadataCustomizer, 
MetadtaServiceVersionCustomizer, and ProtocolPortsMetadataCustomizer, 
explaining the metadata key written, the source of the parameters, how empty 
values are handled, and the overwrite behavior.
   - Adds unit tests covering metadata param extraction (IncludeKeys filtering, 
empty-value skipping, port/protocol always appended), version writing (tri -> 
v2, other/empty protocol -> v1, non-local storage skipped, invalid JSON 
skipped), and protocol port writing (empty list, empty protocol skipped, 
unparsable port recorded as 0).
   
   Refs https://github.com/apache/dubbo-go/issues/3644 (task4)
   
   ### 本地验证
   
   ```
   ~/project/dubbo-go$ go test -count=1 
./registry/servicediscovery/customizer/...
   ok      dubbo.apache.org/dubbo-go/v3/registry/servicediscovery/customizer    
  0.112s
   ```
   
   ### Checklist
   
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to