AlexStocks commented on code in PR #3678:
URL: https://github.com/apache/dubbo-go/pull/3678#discussion_r3804980638
##########
registry/servicediscovery/customizer/metadata_service_version_customizer.go:
##########
@@ -35,7 +35,8 @@ func init() {
extension.AddCustomizers(&MetadtaServiceVersionCustomizer{})
}
-// MetadtaServiceVersionCustomizer will try to add meta-v key to instance
metadata
+// MetadtaServiceVersionCustomizer writes the metadata service version into the
+// instance metadata according to the protocol of the exported service.
Review Comment:
[P2] 这里把版本选择归因于“exported service”的协议，但 Customize 实际读取的是
MetadataServiceURLParamsPropertyName，该值来自 metadata service 自身的 URL。应用同时导出 Dubbo
和 Triple 业务服务时，业务服务协议不会决定 meta-v，当前注释会让调用者误判 v1/v2 的选择依据。请明确改为“metadata service
URL 的 protocol”，并让测试名称和说明保持同一语义。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
