AlexStocks commented on code in PR #158:
URL:
https://github.com/apache/dubbo-go-pixiu-samples/pull/158#discussion_r3802812638
##########
dubbogo/simple/traffic/server/app/main.go:
##########
@@ -25,15 +25,23 @@ import (
)
func main() {
- routers := []string{"/user", "/user/pixiu", "/prefix", "/health"}
+ go startServer(":1315", "v1")
Review Comment:
[P1] WaitGroup 部分已修复，但端口问题只处理了 server
一侧。TRAFFIC_V1_ADDR、TRAFFIC_V2_ADDR、TRAFFIC_V3_ADDR 会改变三个后端的监听地址，pixiu/conf.yaml
和 header-conf.yaml 仍固定拨 127.0.0.1:1315/1316/1317，igt/Makefile
也没有把这些变量渲染进配置；因此设置任意新变量后，同一 sample 启动的 Pixiu
仍拨旧端口，新增的可配置路径端到端不可用。TRAFFIC_GATEWAY_URL 也只改变测试客户端地址，不会改变 Pixiu listener。请让
server、Pixiu 配置和测试 URL 使用同一组可渲染变量，并用非默认端口运行完整 canary/header 两轮集成测试。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
