AlexStocks commented on code in PR #158: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/158#discussion_r3802816670
########## dubbogo/simple/traffic/test/pixiu_header_test.go: ########## @@ -0,0 +1,75 @@ +//go:build manual Review Comment: [P1] 当前 Head 已把 header 场景接入 CI，也补了 X-A+X-B 正例和缺少 X-B 的负例；但这次真实入口验证同时证明原根因仍存在。Samples Integration Test job 95591967766 中 TestHeaderGET1/2/3 均通过，TestHeaderGETMissingB 仅发送 X-A=t1 时仍收到 server v1，断言在 pixiu_header_test.go:100 失败。这说明当前 Pixiu develop 仍没有按配置执行多 header 的 AND 语义。该回归测试现在是有效红灯，不能通过删除或放宽负例来消除；需要先修复/使用已修复的 Pixiu matcher，并让同一端到端 job 转绿后再合并此 PR。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
