XnLemon commented on code in PR #3687: URL: https://github.com/apache/dubbo-go/pull/3687#discussion_r3818765201
########## common/extension/runtime.go: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package extension + +import ( + "fmt" + "strings" +) + +import ( + "dubbo.apache.org/dubbo-go/v3/common" + "dubbo.apache.org/dubbo-go/v3/filter" +) + +// Scope identifies an extension lifecycle level. Definition.Scopes uses the +// values as a bit mask; Context.Scope always contains one concrete scope. +type Scope uint8 + +const ( + // InstanceScope is the lifecycle of a dubbo.Instance. + InstanceScope Scope = 1 << iota + // ClientScope is the lifecycle of a client/consumer. + ClientScope + // ServerScope is the lifecycle of a server/provider. + ServerScope +) + +// RoleNone identifies an Instance context, which has no consumer/provider +// role. It is intentionally outside common.RoleType's URL role constants. +const RoleNone common.RoleType = -1 Review Comment: 想的是 common.RoleType 中已有值表示 consumer、provider等角色 补一个无状态在这就行( 感觉可以改成 ``` const ( RoleNone Role = iota ConsumerRole ProviderRole ) ``` 然后对应位置转common.RoleType -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
