AlexStocks commented on code in PR #3687: URL: https://github.com/apache/dubbo-go/pull/3687#discussion_r3819208688
########## common/extension/runtime.go: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package extension + +import ( + "fmt" + "strings" +) + +import ( + "dubbo.apache.org/dubbo-go/v3/common" + "dubbo.apache.org/dubbo-go/v3/filter" +) + +// Scope identifies an extension lifecycle level. Definition.Scopes uses the +// values as a bit mask; Context.Scope always contains one concrete scope. +type Scope uint8 + +const ( + // InstanceScope is the lifecycle of a dubbo.Instance. + InstanceScope Scope = 1 << iota + // ClientScope is the lifecycle of a client/consumer. + ClientScope + // ServerScope is the lifecycle of a server/provider. + ServerScope +) + +// RoleNone identifies an Instance context, which has no consumer/provider +// role. It is intentionally outside common.RoleType's URL role constants. +const RoleNone common.RoleType = -1 + +// Resource identifies the service or method to which an extension is bound. +// The core constructs Resource values and extensions treat them as read-only. +type Resource struct { Review Comment: [P1] 这里缺少 Issue #3686 验收标准中明确要求的 `Resource.Validate()`。当前 Head 的外部契约探针调用 `r.Validate()` 会直接编译失败：`r.Validate undefined`；同时后续绑定流程也没有入口拒绝 `ServiceKey` 与 `common.ServiceKey(Interface, Group, Version)` 不一致的资源，扩展可能据此把配置或 filter 绑定到错误服务。请实现该校验，并补充一致、不一致及空接口边界测试。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
