AlexStocks commented on code in PR #144: URL: https://github.com/apache/dubbo-getty/pull/144#discussion_r3868534126
########## .travis.yml: ########## @@ -1,42 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed with -# this work for additional information regarding copyright ownership. -# The ASF licenses this file to You under the Apache License, Version 2.0 -# (the "License"); you may not use this file except in compliance with -# the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -language: go - -os: - - linux - -go: - - "1.13" - -env: - - GO111MODULE=on - -install: true - -script: - # license-check - - echo 'start license check' - - sh before_validate_license.sh - - chmod u+x /tmp/tools/license/license-header-checker - - go fmt ./... && [[ -z `git status -s` ]] - - /tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]] - - go mod vendor && go test $(go list ./... | grep -v vendor | grep -v demo) -coverprofile=coverage.txt -covermode=atomic - -after_success: - - bash <(curl -s https://codecov.io/bash) - -notifications: - webhooks: https://oapi.dingtalk.com/robot/send?access_token=75f4f1ec3868508aa89e5a5d6f9d342216809df3ebc8a78c8ae8722848e06166 Review Comment: [P1] 删除这个文件不会撤销这里暴露的钉钉 webhook 凭据；该 access_token 仍可从仓库历史（例如 9958f11 以及本 PR 的 base）读取。如果 token 尚未失效，合并后任何人仍能向对应机器人发消息。请先在钉钉侧撤销或轮换该 token，并给出已经失效的确认；历史重写可以另行评估，但不能把删文件本身当作凭据处置。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
