AlexStocks commented on code in PR #144:
URL: https://github.com/apache/dubbo-getty/pull/144#discussion_r3871600822


##########
.travis.yml:
##########
@@ -1,42 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements.  See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-language: go
-
-os:
-  - linux
-
-go:
-  - "1.13"
-
-env:
-  - GO111MODULE=on
-
-install: true
-
-script:
-  # license-check
-  - echo 'start license check'
-  - sh before_validate_license.sh
-  - chmod u+x /tmp/tools/license/license-header-checker
-  - go fmt ./... && [[ -z `git status -s` ]]
-  - /tmp/tools/license/license-header-checker -v -a -r -i vendor  
/tmp/tools/license/license.txt . go  && [[ -z `git status -s` ]]
-  - go mod vendor && go test $(go list ./... | grep -v vendor | grep -v demo) 
-coverprofile=coverage.txt -covermode=atomic
-
-after_success:
-  - bash <(curl -s https://codecov.io/bash)
-
-notifications:
-  webhooks: 
https://oapi.dingtalk.com/robot/send?access_token=75f4f1ec3868508aa89e5a5d6f9d342216809df3ebc8a78c8ae8722848e06166

Review Comment:
   这项不要求贡献者本人持有钉钉管理权限,但在旧 token 已失效之前风险仍然存在。请由拥有该机器人权限的 maintainer 撤销或轮换 
token,并在本线程确认旧 token 已失效;确认前这条 P1 不能按“删掉配置文件”关闭。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to