GitHub user Tsukikage7 added a comment to the discussion: Dubbo-Go 可观测字段梳理

Thanks for revising the audit and moving it here. I rechecked the current text 
against the pinned `9af40a2b835b5176be453b5f3936b1fc53a7ead4` source. My 
earlier review points are resolved:

- AccessLog now correctly describes the fixed attachment whitelist, 
interface/path fallback and argument-derived fields. Attached `trace_id`, 
`span_id` and `traceparent` are ignored by the builder/formatter; attaching 
them does not enable correlation.
- Metadata mapping labels now correctly distinguish application-level tags from 
attachment-derived `interface`/`group`, including the non-empty `application` 
override. There is no method or service-version label. Register/remove use 
`Succ`; get/listen use `Succ && !Partial`, so partial success counts as failure.
- The log section correctly states that trace integration is disabled by 
default, and automatic correlation requires the trace-aware adapter, a `Ctx*` 
call and a valid span context. The three emitted correlation fields and the 
configurable `CtxError*` behavior match the implementation.
- The pinned behavior remains separate from later merged tests (#3743/#3744) 
and proposed changes (#3551/#3763). RPC fields, error handling, metadata 
representation and the compatibility/follow-up notes are consistent with the 
cited revision.

I independently reran the nine packages listed in Verification from a clean 
archive of that exact commit, with Go 1.25.0 on darwin/arm64 and `-mod=readonly 
-count=1`: all passed.

I have no remaining blocking comments on this documentation audit. This 
satisfies the documentation deliverable in #3720; the runtime gaps listed in 
the follow-up matrix remain separate implementation work.


GitHub link: 
https://github.com/apache/dubbo-go/discussions/3766#discussioncomment-18964029

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: 
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to