b84330808 commented on PR #16550: URL: https://github.com/apache/dubbo/pull/16550#issuecomment-6464074225
Thanks, good catch! Covered the four spots in ae133a7 (AbstractConfigManager, ServiceConfig, StringUtils, DubboBeanDefinitionParser), each with a tr-TR test. While grepping dubbo-common I also fixed the same getter/setter-name pattern in ReflectUtils, MethodUtils, PojoUtils, JavaBeanSerializeUtil, ExtensionLoader and EnvironmentAdapter. Left out on purpose: `AbortPolicyWithReport` lowercases `os.name` before checking for "win" (Turkish Windows gives `wındows`), but that's not a key, so I'd keep it separate. There are also ~25 similar calls in other modules (rpc, remoting, registry, plugins). Happy to do a follow-up for those if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
