bosprimigenious opened a new pull request, #1078: URL: https://github.com/apache/dubbo-go-pixiu/pull/1078
**What this PR does**: Preserve valid escaped paths when HTTPProxy builds the upstream URL. It already copies the decoded `Path` and `RawQuery`; retaining `RawPath` prevents `/files/a%2Fb` from becoming `/files/a/b`. Go URL serialization ignores an invalid or stale RawPath, so rewritten paths retain the existing fallback behavior. Production change: one added field, no new decoding or dependency changes. **Which issue(s) this PR fixes**: Fixes #1077. **Special notes for your reviewer**: Evidence on Go 1.25.14/macOS arm64, unchanged go.mod/go.sum: - Root independently built the pristine and patched CLI gateways and sent real TCP loopback HTTP requests to an actual upstream. Pristine: 4 altered forwarded URIs + 7 preserved forwards. Patched: all 11 forwards preserved. One pre-existing double-slash listener redirect remains 301 with the same Location; it is not counted as a successful forward. No provider/model was used. - Final regression on pristine source: **4 failed / 9 passed leaf cases**. Patched regression: 13 leaf cases plus parent passed; root repeated the final fixture **20 times under race** (280 passing test events, no skips). - Five affected packages: **159 passing test events, 0 failures, 0 skips**, `-race -gcflags=-l -count=1`; scoped vet, gofmt and repository imports-formatter 1.0.10 passed. - Controls include `%25/%3F/%23/%252F`, Unicode, unchanged query strings, plain/double-slash paths, stale RawPath after rewriting and invalid RawPath fallback. - Regression uses the real plugin/factory/filter chain, ClusterManager, endpoint selection, HTTP transport and upstream. Only the process-wide manager accessor is replaced with existing gomonkey. The standalone CLI reproduction has no monkeypatches. The first local test fixture faulted with SIGBUS during macOS teardown after its assertions passed. The final fixture applies the accessor patch before starting its HTTP server and closes client connections/server before resetting the patch. Repeated race runs above use this final fixture; the original failure is retained and its exact low-level cause is not claimed as proven. **Full acceptance: NOT READY; submitted as draft.** Full repository CI/license/lint, Linux/Docker integration and RISC-V builds/runtime are not locally established. Existing PR1074/1076 CI does not validate this head. Source, tests and public prose were generated with OpenAI Codex. Independent automated review and root execution were performed; no human-review claim or personal CLA acceptance is made. Commit includes Signed-off-by. **Does this PR introduce a user-facing change?**: ```release-note HTTPProxy preserves valid percent-escaped request paths when forwarding to an upstream, including encoded path separators. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
