bosprimigenious commented on PR #1078:
URL: https://github.com/apache/dubbo-go-pixiu/pull/1078#issuecomment-6719584032

   Added the comment @AlexStocks asked for in 995d4a7: the assignment now 
spells out that `EscapedPath` only honours `RawPath` while it still decodes to 
`Path`, so a rewrite that changes `Path` falls back to re-escaping rather than 
forwarding a stale encoding.
   
   On the second point — the fix is HTTP-proxy scoped only. Other filters (e.g. 
the generic `http` proxy path) still rebuild URLs from `r.URL.Path`; this PR 
deliberately does not claim to fix those.
   
   Note: `go test ./pkg/filter/http/httpproxy/` panics in my local macOS/arm64 
environment inside the gomonkey-patched fixture 
(`TestForwardedRequestPreservesRawPath/escaped_slash`), and it does the same on 
the pre-change commit, so it looks like a gomonkey/arch limitation rather than 
this diff. CI on Linux is the real signal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to