NeverENG opened a new pull request, #36:
URL: https://github.com/apache/dubbo-net/pull/36

   Refs #16. Closes #35. Documentation coordination: #32 / Draft PR #34.
   
   ## Why
   
   `DubboClient` is the public consumer entry, not the owner of registry SDK 
lookups or the home for every metadata and registry implementation file. This 
PR gives the Provider-discovery lookup to the registry module and makes file 
ownership explicit without changing the consumer API.
   
   ## What changed
   
   - Move metadata managers, signature resolvers, defaults and related models 
to top-level `Metadata/`.
   - Move ZooKeeper/Nacos clients, consumer registration, watcher and related 
models to top-level `Registry/`. All 22 moved files are **byte-for-byte 
unchanged**; public namespaces remain stable for existing callers.
   - Add `Registry/ProviderDiscovery.cs` to own ZooKeeper/Nacos Provider 
lookup, Provider-path parsing, watcher installation and in-flight lookups 
shared by service. `DubboClient` now delegates discovery to it and retains 
client-level orchestration, Driver state, metadata refresh, registry lease 
ownership and cleanup. It does not add a second callable-Provider state store.
   - Keep the metadata-specific discovery error boundary in `DubboClient`; do 
not change overload inference, metadata caching, balancing, transport or public 
configuration.
   
   ## Invariants / scope
   
   No public API or namespace changes, no behavior change intended. Existing 
shared registry references and subscription owner remain the `DubboClient` 
instance. This is **not** the complete #16 client orchestration / Hub / 
lifecycle refactor, and is not a protocol or error-handling change.
   
   ## Validation
   
   - `dotnet build DubboNet.csproj --no-restore -v:q`: passed (3 existing 
warnings).
   - `dotnet test Tests/UnitTestForDubboNet/UnitTestForDubboNet.csproj 
--no-restore -v:q`: **556 passed, 0 failed, 0 skipped**. Existing 
registry-path, Nacos, metadata and driver tests cover the retained contracts; 
no live registry/Provider environment was used.
   - `git diff --check`: passed. Verified all 22 relocated source files are 
byte-identical to `main`.
   
   ## Documentation coordination
   
   #34 is a separate, still-unmerged documentation PR whose code-map pages link 
to old paths under `Clients/`. Before merging either PR, update those links in 
whichever PR remains open; do not merge a broken code map. This branch is based 
on current `main` and does not pull unmerged documentation into the runtime 
change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to