NeverENG commented on code in PR #36:
URL: https://github.com/apache/dubbo-net/pull/36#discussion_r4510760793


##########
Tests/UnitTestForDubboNet/ZooKeeperRegistryPathContractTest.cs:
##########
@@ -18,11 +18,34 @@
 using DubboNet.Clients;
 using DubboNet.Clients.DataModle;
 using DubboNet.Clients.RegistryClient;
+using DubboNet.DubboService;
+using DubboNet.Registry;
 
 namespace UnitTestForDubboNet
 {
     public class ZooKeeperRegistryPathContractTest
     {
+        [Fact]
+        public void SharedProviderUrlContracts_AreOwnedByProtocol()
+        {
+            Assert.Equal("DubboNet.DubboService", 
typeof(ProviderUrlKeys).Namespace);
+            Assert.Equal("DubboNet.DubboService", 
typeof(ProviderProtocolSchemes).Namespace);
+            Assert.Equal("interface", ProviderUrlKeys.Interface);
+            Assert.Equal("dubbo", ProviderProtocolSchemes.Dubbo);
+            Assert.Equal("tri", ProviderProtocolSchemes.Tri);
+        }
+
+        [Fact]
+        public void 
RegistryImplementationHasItsOwnNamespace_WithoutMovingPublicClients()

Review Comment:
   已在 9809cea 加入 ZooKeeper 离线发现分支测试(缺失/空/非空节点、watch 传递、恢复回调),并覆盖完整路径解析。空节点不安装 
watch 是旧缺陷,未把它锁成正确契约,另由 #37 跟踪。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to