Aias00 commented on code in PR #982:
URL: https://github.com/apache/dubbo-go-pixiu/pull/982#discussion_r4522261959


##########
pkg/cmd/gateway.go:
##########
@@ -78,9 +78,16 @@ var (
                        return nil
                },
                RunE: func(cmd *cobra.Command, args []string) error {
-                       err := deploy.start()
-                       if err != nil {
-                               return errors.Wrap(err, "failed to start 
gateway")
+                       startErr := deploy.start()
+                       stopErr := deploy.stop()

Review Comment:
   Added disabled-timeout regression coverage in `bce3ba87`: omitted 
configuration, `0s`, and negative timeouts must not register signal handling or 
run cleanup hooks. Mutation checks confirm it catches both zero-timeout 
registration and cleanup moved before the guard. The PR now has the required 
`release-note` block with `action required`, Nacos 2.x/port requirements, and 
the positive shutdown-timeout requirement.
   
   Also synced current develop in `76c11f03`, resolving the conflict introduced 
by #994 while preserving Nacos cleanup and xDS startup error propagation. Go 
1.25 race tests and golangci-lint v2.4.0 pass for server, CLI, shutdown, and 
xDS packages, including successful/failed startup and real signal shutdown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to