Aias00 commented on code in PR #982:
URL: https://github.com/apache/dubbo-go-pixiu/pull/982#discussion_r4523990751


##########
pkg/adapter/dubboregistry/registry/nacos/registry.go:
##########
@@ -55,7 +55,22 @@ func (n *NacosRegistry) DoSubscribe() error {
 }
 
 func (n *NacosRegistry) DoUnsubscribe() error {
-       panic("implement me")
+       // Stop the background listener first (it drains its watch goroutine), 
then

Review Comment:
   Fixed in `fdccc168` and propagated to #980 (`d94d1a65`). The auth fixture 
file now exactly matches #992/#1062 (`newTestClaims`); all 12 expiration values 
and 51 existing assertions are preserved.
   
   Both merge orders with #992 and #1062 are conflict-free. During the 
full-branch check I also found an independent add/add collision on 
`pkg/client/mq/mq_test.go`; #980's unchanged unsupported-operation test now 
lives in `mq_unsupported_test.go`, retaining both test suites. The combined 
#980/#992 tree passes auth/MQ race tests, and golangci-lint v2.4.0 reports zero 
issues for the changed packages. Both PR descriptions are updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to