Alanxtl commented on code in PR #1158:
URL: https://github.com/apache/dubbo-go-samples/pull/1158#discussion_r4559107519


##########
observability/integration/README_CN.md:
##########
@@ -114,6 +114,57 @@ Dashboard,请显式传入 `-requests 0`。
 docker compose -f observability/integration/docker-compose.yaml down
 ```
 
+### RPC 延迟 Histogram
+
+本分支暂时固定到 [apache/dubbo-go#3791](https://github.com/apache/dubbo-go/pull/3791)
+的公开 SDK 提交。合并本样例前,需要改为包含该功能的上游 SDK 版本;旧版本没有下面的开关。

Review Comment:
   这些都不用写



##########
go.mod:
##########
@@ -2,23 +2,26 @@ module github.com/apache/dubbo-go-samples
 
 go 1.25.0
 
+// Temporary pin for apache/dubbo-go#3791; replace with the upstream version 
after merge.
+replace dubbo.apache.org/dubbo-go/v3 => github.com/dodjdnh/dubbo-go/v3 
v3.0.0-20261112014637-221c96e2271e

Review Comment:
   本地replace不要提交



##########
observability/integration/test_capture.py:
##########


Review Comment:
   test文件目前应该不会自动运行测试,这个samples仓库主要是用于集成测试,测试点都在main.go里面 如果有问题使用panic退出



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to