AlexStocks commented on code in PR #1158:
URL: https://github.com/apache/dubbo-go-samples/pull/1158#discussion_r4577994025


##########
observability/integration/internal/verify/histogram.go:
##########
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package verify
+
+import (
+       "context"
+       "fmt"
+       "io"
+       "math"
+       "net/http"
+       "reflect"
+       "time"
+)
+
+import (
+       dto "github.com/prometheus/client_model/go"

Review Comment:
   已在 head `73b7fc08`(`style(observability): separate histogram import 
groups`,+1/−0 ×2 文件)复核,该问题已修复。两条证据:
   
   1. **本机复跑门禁命令**:把 head 整树 rsync 到一次性副本后跑 `imports-formatter 
1.0.10`(`GOROOT=<go1.25>`,模块上下文内),再用 `rsync -c -i` 
逐文件比对,**零文件差异**。同一次会话里用同样命令处理一个把 `dto "..."` 与不带别名的 import 
写在同一子组的对照文件,能稳定插入空行,说明工具判据有效、不是空跑。
   2. **CI**:`Build And Integration` 的 `Format code` step 在 `73b7fc08` 上为 
`success`(此前在旧 head 上失败)。
   
   仍为红的是同一 job 的 `Integration test` step 与 `lint` job,根因是依赖前置而非本 PR 逻辑:samples 
CI 会把 `dubbo-go/v3` replace 到 `main`,而 `metrics.WithHistogramEnabled` 目前只在 
#3791 的 `develop` 分支上,维护者已在 #3791 说明 develop→main 同步由他处理。本条不改变定级,仅记录复核结果。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to