Gitesg commented on PR #3830: URL: https://github.com/apache/dubbo-go/pull/3830#issuecomment-6942015112
Thanks @AlexStocks for the additional verification. I agree that removing TestListener from RACE_SKIP_TESTS would make the race-test suite unreliable because of the existing Agollo race. I've kept TestListener in the skip list and documented the Agollo v4.4.0 issue in the Makefile. The focused TestApolloListenerConcurrentAccess`test remains race-enabled and verifies the listener synchronization fix. I also reproduced the Agollo race on upstream `develop`, confirming that it is unrelated to these changes. I've updated the PR accordingly. Thank you for reviewing and helping identify these issues! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
