Gitesg commented on PR #3830: URL: https://github.com/apache/dubbo-go/pull/3830#issuecomment-6942042214
Thanks you @Alanxtl for catching this. I investigated the race by comparing my branch against upstream develop. The same Agollo v4.4.0 race (getAppConfig vs SyncAndUpdate) reproduces on both branches, so it is unrelated to the listener synchronization changes in this PR. I've kept TestListener in RACE_SKIP_TESTS and retained TestApolloListenerConcurrentAccess as a separate race-enabled regression test for the listener map synchronization. I've also updated the Makefile comment to document why the test is skipped and resolved the conflict with the latest develop. Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
