AlexStocks commented on a change in pull request #1161:
URL: https://github.com/apache/dubbo-go/pull/1161#discussion_r615338460
##########
File path: metadata/report/delegate/delegate_report.go
##########
@@ -300,3 +305,13 @@ func (mr *MetadataReport)
doHandlerMetadataCollection(metadataMap map[*identifie
}
return false
}
+
+func (mr *MetadataReport) PublishAppMetadata(identifier
*identifier.SubscriberMetadataIdentifier, info *common.MetadataInfo) error {
+ report := instance.GetMetadataReportInstance()
+ return report.PublishAppMetadata(identifier, info)
+}
+
+func (mr *MetadataReport) GetAppMetadata(identifier
*identifier.SubscriberMetadataIdentifier) (*common.MetadataInfo, error) {
Review comment:
// nolint
##########
File path: metadata/report/etcd/report.go
##########
@@ -50,6 +50,16 @@ type etcdMetadataReport struct {
root string
}
+func (e *etcdMetadataReport) GetAppMetadata(metadataIdentifier
*identifier.SubscriberMetadataIdentifier) (*common.MetadataInfo, error) {
Review comment:
// nolint
##########
File path: metadata/report/etcd/report.go
##########
@@ -50,6 +50,16 @@ type etcdMetadataReport struct {
root string
}
+func (e *etcdMetadataReport) GetAppMetadata(metadataIdentifier
*identifier.SubscriberMetadataIdentifier) (*common.MetadataInfo, error) {
+ // TODO will implement
+ panic("implement me")
+}
+
+func (e *etcdMetadataReport) PublishAppMetadata(metadataIdentifier
*identifier.SubscriberMetadataIdentifier, info *common.MetadataInfo) error {
Review comment:
// nolint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
