AlexStocks commented on a change in pull request #1161:
URL: https://github.com/apache/dubbo-go/pull/1161#discussion_r615338542
##########
File path: metadata/service/inmemory/service.go
##########
@@ -220,6 +235,20 @@ func (mts *MetadataService)
GetServiceDefinitionByServiceKey(serviceKey string)
return v.(string), nil
}
+func (mts *MetadataService) GetMetadataInfo(revision string)
(*common.MetadataInfo, error) {
Review comment:
// nolint
##########
File path: metadata/service/inmemory/service.go
##########
@@ -220,6 +235,20 @@ func (mts *MetadataService)
GetServiceDefinitionByServiceKey(serviceKey string)
return v.(string), nil
}
+func (mts *MetadataService) GetMetadataInfo(revision string)
(*common.MetadataInfo, error) {
+ if revision == "" {
+ return mts.metadataInfo, nil
+ }
+ if mts.metadataInfo.CalAndGetRevision() != revision {
+ return nil, nil
+ }
+ return mts.metadataInfo, nil
+}
+
+func (mts *MetadataService) GetExportedServiceURLs() []*common.URL {
Review comment:
// nolint
##########
File path: metadata/service/inmemory/service.go
##########
@@ -229,3 +258,11 @@ func (mts *MetadataService) RefreshMetadata(string,
string) (bool, error) {
func (mts *MetadataService) Version() (string, error) {
return version, nil
}
+
+func (mts *MetadataService) GetMetadataServiceURL() *common.URL {
Review comment:
// nolint
##########
File path: metadata/service/inmemory/service.go
##########
@@ -229,3 +258,11 @@ func (mts *MetadataService) RefreshMetadata(string,
string) (bool, error) {
func (mts *MetadataService) Version() (string, error) {
return version, nil
}
+
+func (mts *MetadataService) GetMetadataServiceURL() *common.URL {
+ return mts.metadataServiceURL
+}
+
+func (mts *MetadataService) SetMetadataServiceURL(url *common.URL) {
Review comment:
// nolint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
