ztelur commented on a change in pull request #1271:
URL: https://github.com/apache/dubbo-go/pull/1271#discussion_r657560590
##########
File path: config/reference_config.go
##########
@@ -61,7 +61,7 @@ type ReferenceConfig struct {
Params map[string]string `yaml:"params"
json:"params,omitempty" property:"params"`
invoker protocol.Invoker
urls []*common.URL
- Generic bool `yaml:"generic" json:"generic,omitempty"
property:"generic"`
+ Generic string `yaml:"generic" json:"generic,omitempty"
property:"generic"`
Review comment:
should use protocol instead of expanding the enum of generic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
