xavier-niu commented on a change in pull request #1271:
URL: https://github.com/apache/dubbo-go/pull/1271#discussion_r657572096
##########
File path: filter/filter_impl/generic_service_filter.go
##########
@@ -60,39 +59,53 @@ func (ef *GenericServiceFilter) Invoke(ctx context.Context,
invoker protocol.Inv
if invocation.MethodName() != constant.GENERIC ||
len(invocation.Arguments()) != 3 {
return invoker.Invoke(ctx, invocation)
}
+ logger.Debugf("[Generic Service Filter] arguments: %v",
invocation.Arguments())
+ logger.Debugf("[Generic Service Filter] attachments: %v",
invocation.Attachments())
var (
- ok bool
- err error
- methodName string
- newParams []interface{}
- genericKey string
- argsType []reflect.Type
- oldParams []hessian.Object
+ isAssignSuccess bool
Review comment:
Why don't use ok? It seems that ok and isAssginSuccess are the same
stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
