24kpure commented on a change in pull request #8441:
URL: https://github.com/apache/dubbo/pull/8441#discussion_r684896761
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/ShortestResponseLoadBalance.java
##########
@@ -77,11 +120,22 @@
shortestIndexes[shortestCount++] = i;
totalWeight += afterWarmup;
if (sameWeight && i > 0
- && afterWarmup != firstWeight) {
+ && afterWarmup != firstWeight) {
sameWeight = false;
}
}
}
+
+ if (System.currentTimeMillis() - lastUpdateTime > SLIDE_PERIOD
+ && onResetSlideWindow.compareAndSet(false, true)) {
+ //reset slideWindowData in async way
+ Executors.newSingleThreadExecutor().execute(() -> {
Review comment:
You are right. I will fix the prolem later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
