AlexStocks commented on a change in pull request #1453:
URL: https://github.com/apache/dubbo-go/pull/1453#discussion_r707391859
##########
File path: common/extension/config_loader_processor.go
##########
@@ -77,8 +77,9 @@ func ResetURL() {
// emit
func emit(funcName string, val []reflect.Value) {
+ var values []reflect.Value
for _, p := range GetConfigLoadProcessors() {
- values := []reflect.Value{reflect.ValueOf(p)}
+ values = []reflect.Value{reflect.ValueOf(p)}
Review comment:
没看出来你这样的改进有啥好处
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]