AlexStocks commented on a change in pull request #1453: URL: https://github.com/apache/dubbo-go/pull/1453#discussion_r709989958
########## File path: common/extension/config_load_processor.go ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package extension + +import ( + "reflect" +) + +import ( + "github.com/apache/dubbo-go/common" + "github.com/apache/dubbo-go/common/constant" + "github.com/apache/dubbo-go/config/interfaces" +) + +const ( + LoadProcessReferenceConfigFunctionName = "LoadProcessReferenceConfig" + LoadProcessServiceConfigFunctionName = "LoadProcessServiceConfig" + AfterAllReferencesConnectCompleteFunctionName = "AfterAllReferencesConnectComplete" + AfterAllServicesListenCompleteFunctionName = "AfterAllServicesListenComplete" + BeforeShutdownFunctionName = "BeforeShutdown" +) + +var ( + configLoadProcessorHolder *interfaces.ConfigLoadProcessorHolder + + loadProcessors = make(map[string]interfaces.ConfigLoadProcessor) + loadProcessorValues = make(map[string]reflect.Value) + + referenceURL = make(map[string][]*common.URL) + serviceURL = make(map[string][]*common.URL) +) + +func init() { + configLoadProcessorHolder = new(interfaces.ConfigLoadProcessorHolder) +} + +// SetConfigLoadProcessor registers a ConfigLoadProcessor with the given name. +func SetConfigLoadProcessor(name string, processor interfaces.ConfigLoadProcessor) { + configLoadProcessorHolder.Lock() + loadProcessors[name] = processor + loadProcessorValues[name] = reflect.ValueOf(processor) + configLoadProcessorHolder.Unlock() +} + +// GetConfigLoadProcessor finds a ConfigLoadProcessor by name. +func GetConfigLoadProcessor(name string) interfaces.ConfigLoadProcessor { + return loadProcessors[name] +} + +// RemoveConfigLoadProcessor remove process from processors. +func RemoveConfigLoadProcessor(name string) { + configLoadProcessorHolder.Lock() + delete(loadProcessors, name) + delete(loadProcessorValues, name) + configLoadProcessorHolder.Unlock() +} + +// GetConfigLoadProcessors returns all registered instances of ConfigLoadProcessor. +func GetConfigLoadProcessors() []interfaces.ConfigLoadProcessor { + configLoadProcessorHolder.Lock() + ret := make([]interfaces.ConfigLoadProcessor, 0, len(loadProcessors)) + for _, v := range loadProcessors { + ret = append(ret, v) + } + configLoadProcessorHolder.Unlock() + return ret +} + +// GetReferenceURL returns all reference URL +func GetReferenceURL() map[string][]*common.URL { + return referenceURL Review comment: 两个问题： 1 读取动作需要加锁； 2 怎么保证外面的函数不会对 referenceURL 产生写动作？这个问题你要么在函数上加上注释说明白，要么老老实实返回 referenceURL 的一个 copy ########## File path: common/extension/config_load_processor.go ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package extension + +import ( + "reflect" +) + +import ( + "github.com/apache/dubbo-go/common" + "github.com/apache/dubbo-go/common/constant" + "github.com/apache/dubbo-go/config/interfaces" +) + +const ( + LoadProcessReferenceConfigFunctionName = "LoadProcessReferenceConfig" + LoadProcessServiceConfigFunctionName = "LoadProcessServiceConfig" + AfterAllReferencesConnectCompleteFunctionName = "AfterAllReferencesConnectComplete" + AfterAllServicesListenCompleteFunctionName = "AfterAllServicesListenComplete" + BeforeShutdownFunctionName = "BeforeShutdown" +) + +var ( + configLoadProcessorHolder *interfaces.ConfigLoadProcessorHolder + + loadProcessors = make(map[string]interfaces.ConfigLoadProcessor) + loadProcessorValues = make(map[string]reflect.Value) + + referenceURL = make(map[string][]*common.URL) + serviceURL = make(map[string][]*common.URL) +) + +func init() { + configLoadProcessorHolder = new(interfaces.ConfigLoadProcessorHolder) +} + +// SetConfigLoadProcessor registers a ConfigLoadProcessor with the given name. +func SetConfigLoadProcessor(name string, processor interfaces.ConfigLoadProcessor) { + configLoadProcessorHolder.Lock() + loadProcessors[name] = processor + loadProcessorValues[name] = reflect.ValueOf(processor) + configLoadProcessorHolder.Unlock() +} + +// GetConfigLoadProcessor finds a ConfigLoadProcessor by name. +func GetConfigLoadProcessor(name string) interfaces.ConfigLoadProcessor { + return loadProcessors[name] +} + +// RemoveConfigLoadProcessor remove process from processors. +func RemoveConfigLoadProcessor(name string) { + configLoadProcessorHolder.Lock() + delete(loadProcessors, name) + delete(loadProcessorValues, name) + configLoadProcessorHolder.Unlock() +} + +// GetConfigLoadProcessors returns all registered instances of ConfigLoadProcessor. +func GetConfigLoadProcessors() []interfaces.ConfigLoadProcessor { + configLoadProcessorHolder.Lock() + ret := make([]interfaces.ConfigLoadProcessor, 0, len(loadProcessors)) + for _, v := range loadProcessors { + ret = append(ret, v) + } + configLoadProcessorHolder.Unlock() + return ret +} + +// GetReferenceURL returns all reference URL +func GetReferenceURL() map[string][]*common.URL { + return referenceURL +} + +// GetServiceURL returns all service URL +func GetServiceURL() map[string][]*common.URL { + return serviceURL Review comment: 同上 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
