AlexStocks commented on a change in pull request #1491:
URL: https://github.com/apache/dubbo-go/pull/1491#discussion_r717219283
##########
File path: config/application_config.go
##########
@@ -113,3 +113,53 @@ func WithMetadataType(metadataType string)
ApplicationConfigOpt {
ac.MetadataType = metadataType
}
}
+
+func NewApplicationConfigBuilder() *ApplicationConfigBuilder {
+ return &ApplicationConfigBuilder{application: &ApplicationConfig{}}
+}
+
+type ApplicationConfigBuilder struct {
+ application *ApplicationConfig
+}
+
+func (acb *ApplicationConfigBuilder) Organization(organization string)
*ApplicationConfigBuilder {
Review comment:
赋值函数为啥不在前面加上 Set?
##########
File path: config/root_config.go
##########
@@ -278,3 +278,88 @@ func WithRootCenterConfig(centerConfig *CenterConfig)
RootConfigOpt {
rc.ConfigCenter = centerConfig
}
}
+
+func NewRootConfigBuilder() *RootConfigBuilder {
+ return &RootConfigBuilder{rootConfig: &RootConfig{}}
+}
+
+type RootConfigBuilder struct {
+ rootConfig *RootConfig
+}
+
+func (rb *RootConfigBuilder) Application(application *ApplicationConfig)
*RootConfigBuilder {
Review comment:
加上 Set 前缀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
