Mulavar commented on a change in pull request #1491:
URL: https://github.com/apache/dubbo-go/pull/1491#discussion_r718123474
##########
File path: config/config_loader.go
##########
@@ -188,19 +188,19 @@ func RPCService(service common.RPCService) {
// So you don't need to worry about the race condition
func GetMetricConfig() *MetricConfig {
// todo
- //if GetBaseConfig().MetricConfig == nil {
+ //if GetBaseConfig().Metric == nil {
Review comment:
解释一下上面的问题，
&ApplicationConfigBuilder{
key1:value1,
key2:value2,
}
是一种初始化方式，这个builder是另一个问题，是前段时间讨论后针对目前with的config
api一个替换做法，我个人理解builder不算是java专有的吧，这个模式go里面也有用，但是java比较普遍，我们也是讨论了觉得这种方式可读性比with更强所以借鉴这种写法。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
