zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r728718989
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperClient.java
##########
@@ -55,7 +55,9 @@
boolean isConnected();
- void close();
+ void close(String application);
Review comment:
i don't think so. if you want share zkclient among all applications,
then zkclient close method should know which application is going to be
destroyed.
one application is going to be destroyed does not mean the global
ZookeeperTransporter that shared between all applications is also going to be
destroyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
