zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r728777568
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperClient.java
##########
@@ -55,7 +55,9 @@
boolean isConnected();
- void close();
+ void close(String application);
Review comment:
zookeeper client codes are reverted, now zkClient is closed by
ZookeeperTransporter(zkClient, application) which might be called by
ZookeeperRegistry.destroy() or ZookeeperDynamicConfiguration.doClose().
Adding ApplicationDeployer.postDestroy method is much more than what i was
expecting, so i abandon to do it and wait for you fix.
pls review again.
@kylixs
##########
File path:
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/zookeeper/ZookeeperClient.java
##########
@@ -55,7 +55,9 @@
boolean isConnected();
- void close();
+ void close(String application);
Review comment:
zookeeper client codes are reverted, now zkClient is closed by
ZookeeperTransporter(zkClient, application) which might be called by
ZookeeperRegistry.destroy() or ZookeeperDynamicConfiguration.doClose().
Adding ApplicationDeployer.postDestroy method is much more than what i was
expecting, so i abandon to do it and wait for your fix.
pls review again.
@kylixs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
