zrlw commented on a change in pull request #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r734979475



##########
File path: 
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java
##########
@@ -95,6 +98,10 @@
     private static final AtomicIntegerFieldUpdater<HashedWheelTimer> 
WORKER_STATE_UPDATER =
             AtomicIntegerFieldUpdater.newUpdater(HashedWheelTimer.class, 
"workerState");
 
+    private static final ExecutorService DEFAULT_TIMER_TASK_EXECUTOR =
+            
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors(),
+            new NamedThreadFactory("HashedWheelTimerTask", true));
+

Review comment:
       this is a issue which is triggered by  github concurrently running unit 
tests.
   if  test class A is starting while test class B is destroying,  the global 
resources which include GlobalResourcesRepository will be destroyed ,  it 
seemed that github use same main thread to destroy and start test class.
   just like the integration test issue i mentioned at #9079
   it seemed that we should change github ut and it from parallel to serial 
mode.
   @AlbumenJ  @kylixs 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to