zrlw commented on a change in pull request #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r735204664



##########
File path: 
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java
##########
@@ -95,6 +98,10 @@
     private static final AtomicIntegerFieldUpdater<HashedWheelTimer> 
WORKER_STATE_UPDATER =
             AtomicIntegerFieldUpdater.newUpdater(HashedWheelTimer.class, 
"workerState");
 
+    private static final ExecutorService DEFAULT_TIMER_TASK_EXECUTOR =
+            
Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors(),
+            new NamedThreadFactory("HashedWheelTimerTask", true));
+

Review comment:
       addApplication() and tryDestroy() in FrameworkModel should not run in 
parallel mode, i added synchronized lock but it doesn‘t solve another issue 
#9079, it seemed all the methods in the same test class are running on parallel 
mode, but this is not expected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to