kylixs commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r735224912
##########
File path:
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfigurationFactory.java
##########
@@ -30,11 +29,8 @@
private ZookeeperTransporter zookeeperTransporter;
- private ApplicationModel applicationModel;
-
- public ZookeeperDynamicConfigurationFactory(ApplicationModel
applicationModel) {
- this.applicationModel = applicationModel;
- this.zookeeperTransporter =
ZookeeperTransporter.getExtension(applicationModel);
+ public ZookeeperDynamicConfigurationFactory() {
Review comment:
Why remove the constructor ? It should have a constructor pass
ScopeModel.
```
public ZookeeperDynamicConfigurationFactory(ApplicationModel
applicationModel)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
