zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r735237518
##########
File path:
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/DubboBootstrapMultiInstanceTest.java
##########
@@ -379,7 +379,8 @@ public void testMultiProviderApplicationsStopOneByOne() {
providerBootstrap2.stop();
// shutdown register center after dubbo application to avoid
unregister services blocking
registryCenter2.shutdown();
- checkUnclosedThreadsOfApp(stackTraces2, "Found unclosed threads of
app 2: ", null);
+ // NettyServer is not closed as DubboTestChecker is still running.
+ checkUnclosedThreadsOfApp(stackTraces2, "Found unclosed threads of
app 2: ", new String[]{EVENT_LOOP_BOSS_POOL_NAME,
"Dubbo-global-shared-handler"});
Review comment:
run it as junit test, ten of ten tests failed if do not ignore them or
do not disable DubboTestChecker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
