zrlw commented on a change in pull request #9015:
URL: https://github.com/apache/dubbo/pull/9015#discussion_r739749247
##########
File path:
dubbo-config/dubbo-config-spring/src/test/java/org/apache/dubbo/config/spring/ConfigTest.java
##########
@@ -554,12 +554,12 @@ public void test_noMethodInterface_methodsKeyHasValue()
throws Exception {
} finally {
ctx.stop();
ctx.close();
- // Check if the port is closed
- if (urls != null) {
- for (URL url : urls) {
-
Assertions.assertFalse(NetUtils.isPortInUsed(url.getPort()));
- }
- }
+ // the closed port that state is TIME_WAIT could not be used if
not set reuse option on some OS.
+// if (urls != null) {
+// for (URL url : urls) {
+//
Assertions.assertFalse(NetUtils.isPortInUsed(url.getPort()));
Review comment:
because usually it didn't passed on windows, see tcp TIME_OUT port state
& SO_REUSEPORT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
